fix: add app client support for nested method call #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcampbell
changed the title
robdmoore
reviewed
Oct 18, 2024
| // An undefined transaction argument signals that the value will be supplied by a method call argument | ||
| if (algosdk.abiTypeIsTransaction(params.method.args[i].type) && transactionsForGroup.length > 0) { | ||
| // Move the last transaction from the group to the method call arguments to appease algosdk | ||
| const placeholderTransaction = transactionsForGroup.splice(-1, 1)[0] |
There was a problem hiding this comment.
splice mutates the array - desired?
robdmoore
reviewed
Oct 18, 2024
| @@ -1218,6 +1236,8 @@ export default class AlgoKitComposer { | |||
| return { atc: this.atc, transactions: this.atc.buildGroup(), methodCalls: this.atc['methodCalls'] } | |||
| } | |||
|
|
|||
| // TODO: NC - Docs about the behaviour | |||
robdmoore
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the correct transaction group is built when an ABI method call has an ABI method call argument.