New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cover fees for app call transactions that send inner transactions #357

Merged

neilcampbell merged 10 commits into main from cover-fees

Jan 17, 2025

Contributor

neilcampbell commented Dec 16, 2024 •

edited

Loading

Add support for calculating fees for app call transactions that send inner transactions.

neilcampbell added 2 commits

December 16, 2024 21:43


          feat: cover app call inner transaction fees

215486f

feat: handle returning maxfee

chore: change mechanism for resolving method info

chore: proper fee calcs

feat: require a max fee to be set

chore: adjust test names

chore: more tweaks

chore: docs


          chore: some self review fixes

b7f4760

neilcampbell requested a review from robdmoore

December 16, 2024 14:41

neilcampbell changed the title ~~Cover fees~~ feat: cover fees for app call transactions that send inner transactions

neilcampbell commented

View reviewed changes

src/transaction/transaction.ts Show resolved Hide resolved

src/transaction/transaction.ts Show resolved Hide resolved

src/types/app-deployer.ts Show resolved Hide resolved

src/transaction/transaction.ts Outdated Show resolved Hide resolved


          chore: adding an additional test

neilcampbell force-pushed the cover-fees branch from 91ebea9 to 7684322 Compare

December 17, 2024 02:05


          chore: add test to check ensure_budget

dd9c9a8

robdmoore reviewed

View reviewed changes

docs/capabilities/transaction-composer.md Outdated Show resolved Hide resolved

robdmoore reviewed

View reviewed changes

src/transaction/transaction.spec.ts Outdated Show resolved Hide resolved

robdmoore reviewed

View reviewed changes

src/transaction/transaction.spec.ts Show resolved Hide resolved

robdmoore reviewed

View reviewed changes

src/transaction/transaction.spec.ts Outdated Show resolved Hide resolved

robdmoore reviewed

View reviewed changes

src/types/composer.ts Show resolved Hide resolved

robdmoore reviewed

View reviewed changes

src/types/composer.ts Show resolved Hide resolved


          chore: PR tweaks

6dab2d8

robdmoore reviewed

View reviewed changes

src/types/composer.ts Outdated Show resolved Hide resolved

robdmoore approved these changes

View reviewed changes

neilcampbell added 5 commits

January 9, 2025 14:07


          chore: merge branch into main

45977a8


          docs: add section on covering app call op budget

5ec1452


          chore: merge main into branch

6796ce4


          chore: a couple of doc tweaks for algorandFixture

6a92dde


          chore: adjust terminology based on feedback

f194261

chore: small refinements to naming

neilcampbell force-pushed the cover-fees branch from 7b14b82 to f194261 Compare

January 17, 2025 07:33

neilcampbell merged commit 2c2dd78 into main

2 checks passed

neilcampbell deleted the cover-fees branch

January 17, 2025 12:59

neilcampbell mentioned this pull request

feat: algokit-utils-py v3 implementation algorandfoundation/algokit-utils-py#119

Merged

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet