Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customized origin parser in Dubbo adapter #1476

Closed
sczyh30 opened this issue May 13, 2020 · 6 comments · Fixed by #1555
Closed

Support customized origin parser in Dubbo adapter #1476

sczyh30 opened this issue May 13, 2020 · 6 comments · Fixed by #1555
Labels
area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Milestone
1.8.0

Comments

@sczyh30
Copy link
Member

sczyh30 commented May 13, 2020

Issue Description

Type: feature request

Describe what happened (or what feature you want)

Support customized origin parser in Dubbo provider filter.
@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. good first issue Good for newcomers area/integrations Issues or PRs related to integrations with open-source components labels May 13, 2020
@hermitcai
Copy link

Can i claim?

@cityiron
Copy link
Contributor

I can do this

@sczyh30
Copy link
Member Author

sczyh30 commented May 25, 2020

Looking forward to your PR!

@hermitcai
Copy link

me or ?

@sczyh30
Copy link
Member Author

sczyh30 commented May 29, 2020

Quick bird picks the PR :)

@cityiron cityiron mentioned this issue Jun 17, 2020
Merged
@sczyh30 sczyh30 added this to the 1.8.0 milestone Jun 28, 2020
@sczyh30
Copy link
Member Author

sczyh30 commented Jun 29, 2020

This has been resolved for Dubbo 2.6.x adapter via #1555 by @dogbaobao. PRs for 2.7.x adapter are welcomed!

@sczyh30 sczyh30 mentioned this issue Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Customized handler parser in Dubbo provider filter. cityiron/Sentinel
3 participants
@sczyh30 @hermitcai @cityiron