Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenSergo ConcurrencyLimitStrategy in sentinel-datasource-opensergo #2942

Closed
sczyh30 opened this issue Nov 8, 2022 · 2 comments · Fixed by #2965
Closed

Add support for OpenSergo ConcurrencyLimitStrategy in sentinel-datasource-opensergo #2942

sczyh30 opened this issue Nov 8, 2022 · 2 comments · Fixed by #2965
Labels
area/data-source Issues or PRs related to data-source extension good first issue Good for newcomers kind/feature Category issues or prs related to feature request.
Milestone
v2.0.0

Comments

@sczyh30
Copy link
Member

sczyh30 commented Nov 8, 2022 •
edited
Loading

Issue Description

Type: feature request

Describe what happened (or what feature you want)

Add support for OpenSergo ConcurrencyLimitStrategy in sentinel-datasource-opensergo.

The ConcurrencyLimitStrategy should also be converted to FlowRule, with grade=0 (metricType=concurrency).

Umbrella issue: #2841
@sczyh30 sczyh30 added good first issue Good for newcomers kind/feature Category issues or prs related to feature request. area/data-source Issues or PRs related to data-source extension labels Nov 8, 2022
@sczyh30 sczyh30 added this to the v2.0.0 milestone Nov 8, 2022
@selectbook
Copy link

Hello, I'm interested in contributing to this issue. can I hava a try?

@sczyh30
Copy link
Member Author

sczyh30 commented Nov 9, 2022

Hello, I'm interested in contributing to this issue. can I have a try?

Hi, contributions are welcome! You may refer to existing implementation: #2842

@pandaapo pandaapo mentioned this issue Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/data-source Issues or PRs related to data-source extension good first issue Good for newcomers kind/feature Category issues or prs related to feature request.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Fix issue to add support for OpenSergo ConcurrencyLimitStrategy. pandaapo/Sentinel
2 participants
@selectbook @sczyh30