Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] NPE causes SystemRule cannot effect #3336

Open
Daydreamer-ia opened this issue Feb 17, 2024 · 1 comment
Open

[BUG] NPE causes SystemRule cannot effect #3336

Daydreamer-ia opened this issue Feb 17, 2024 · 1 comment

Comments

@Daydreamer-ia
Copy link

Issue Description

Type: bug report

Describe what happened

版本: V1.8.6
由于系统规则抛出时是直接抛出，没有包裹 Rule 对象。而在 LogSlot 记录日志时，会去获取 Rule 对象，导致此处出现 NPE ，使得 SystemBlockException 没有抛出被吞掉，使得系统规则失效。
image
下图是发生 NPE 时，导致 SystemBlockException 被吞掉的情况，其他限流规则是否会被吞掉，还待测试。
1a5772737097e46e3c2802fc46640a1

Describe what you expected to happen

不应该出现 NPE 导致规则失效

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@wangxiaof
Copy link

#2980
#3084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wangxiaof @Daydreamer-ia