Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pha: support plugin-pha interface optional #5978

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

MrpandaLiu
Copy link
Collaborator

@MrpandaLiu MrpandaLiu commented Feb 27, 2023

插件调用参数无法仅添加preload:true,因为类型要求所有key必填

answershuto
answershuto previously approved these changes Feb 27, 2023
@@ -0,0 +1,5 @@
---
'@ice/plugin-pha': major
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch 更新是不是就好了, 不需要更新大版本号的

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch

刚才啪啪敲回车没注意这里可以选择,直接改成patch是不是就可以了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch 更新是不是就好了, 不需要更新大版本号的

改成patch了

@wssgcg1213 wssgcg1213 changed the base branch from master to release/next February 27, 2023 09:02
@wssgcg1213 wssgcg1213 dismissed answershuto’s stale review February 27, 2023 09:02

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants