Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optional ts type of onDemand #6010

Merged
merged 1 commit into from
Mar 6, 2023
Merged

chore: optional ts type of onDemand #6010

merged 1 commit into from
Mar 6, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Mar 6, 2023

server.onDemand is optional.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/next@18ea5b2). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/next    #6010   +/-   ##
===============================================
  Coverage                ?   81.94%           
===============================================
  Files                   ?      197           
  Lines                   ?    18104           
  Branches                ?     2356           
===============================================
  Hits                    ?    14836           
  Misses                  ?     3233           
  Partials                ?       35           
Impacted Files Coverage Δ
packages/ice/src/types/userConfig.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luhc228 luhc228 merged commit acfd0a0 into release/next Mar 6, 2023
@luhc228 luhc228 deleted the chore/ts-type branch March 6, 2023 08:58
@ClarkXia ClarkXia mentioned this pull request Mar 7, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants