feat: support route index and nested url without nested layout #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
冲突 |
ClarkXia
reviewed
Mar 6, 2023
packages/route-manifest/src/index.ts
Outdated
| const nextChar = i < partialRouteId.length - 1 ? partialRouteId.charAt(i + 1) : undefined; | ||
|
|
||
| function isNewEscapeSequence() { |
There was a problem hiding this comment.
函数声明尽量不要在循环体内，是不是直接变量声明就行了
|
test case 需要覆盖新规则 |
chenjun1011
reviewed
Mar 7, 2023
| } | ||
|
|
||
| if (isNewEscapeSequence()) { | ||
| inEscapeSequence++; |
done |
ClarkXia
approved these changes
Mar 8, 2023
chenjun1011
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a.b.c.tsx扁平文件名代替a/b/c.tsx嵌套目录 来生成/a/b/c嵌套 url。Ref: https://remix.run/docs/en/main/guides/routing#nested-urls-without-nesting-layouts