feat: async data loader #6137
Merged
feat: async data loader #6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
reviewed
Apr 7, 2023
packages/runtime/src/routes.tsx
Outdated
| return routeData; | ||
| }; | ||
|
|
||
| if (loaderConfig?.[1]?.defer) { |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release/next #6137 +/- ##
================================================
+ Coverage 81.78% 81.82% +0.03%
================================================
Files 199 199
Lines 17931 18168 +237
Branches 2324 2357 +33
================================================
+ Hits 14665 14866 +201
- Misses 3232 3265 +33
- Partials 34 37 +3
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ClarkXia
reviewed
Apr 18, 2023
| } | ||
|
|
||
| const loader = appExport?.dataLoader; | ||
| const appDataLoaderConfig = appExport?.dataLoader; |
| } from '../src/routes.js'; | ||
| import { useData } from '../src/singleRouter'; |
| @@ -20,16 +22,16 @@ export interface LoadRoutesDataOptions { | |||
| renderMode: RenderMode; | |||
| } | |||
|
|
|||
| export function defineDataLoader(dataLoaderConfig: DataLoaderConfig): DataLoaderConfig { | |||
| return dataLoaderConfig; | |||
| export function defineDataLoader(dataLoader: Loader, options?: DataLoaderOptions): DataLoaderConfig { | |||
There was a problem hiding this comment.
如果不走 defineDataLoader，那就是数组嵌套了？
const dataLoader = [[() => {}, {}], {defer: ture}]感觉还是对象会比较清晰
ClarkXia
reviewed
Apr 24, 2023
| dataLoader: async () => ({ type: 'getData' }), | ||
| serverDataLoader: async () => ({ type: 'getServerData' }), | ||
| staticDataLoader: async () => ({ type: 'getStaticData' }), | ||
| dataLoader: { loader: async () => ({ type: 'getData' }) }, |
There was a problem hiding this comment.
现在的变化是不是有 breakchange，如果不通过 defineDataLoader 的形式指定的话
There was a problem hiding this comment.
可以通过兼容 function 或 数组的场景来实现
ClarkXia
approved these changes
Apr 24, 2023
answershuto
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: #6124