Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/rax compat #6493

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Refactor/rax compat #6493

merged 3 commits into from
Sep 11, 2023

Conversation

wssgcg1213
Copy link
Collaborator

@wssgcg1213 wssgcg1213 commented Aug 25, 2023

  1. 升级了 @swc/helpers 的版本, 主流都是 0.5.1 以上, 0.4 反而会有多版本打包问题
  2. 将 createReactClass 的实现迁移为最简实现,干掉 create-react-class 这个外部包的引用, 减少体积

1. update @swc/helpers version to latest.
2. relplace create react class with simple impl.
@wssgcg1213 wssgcg1213 changed the base branch from master to release/next August 25, 2023 09:48
@wssgcg1213
Copy link
Collaborator Author

待补充 createReactClass 的测试用例

Base automatically changed from release/next to master August 31, 2023 07:49
@wssgcg1213
Copy link
Collaborator Author

image

@wssgcg1213 wssgcg1213 self-assigned this Sep 8, 2023
@wssgcg1213 wssgcg1213 added the need review Need Review label Sep 8, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 96.06% and project coverage change: +1.09% 🎉

Comparison is base (99c0dd2) 79.19% compared to head (721000f) 80.29%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6493      +/-   ##
==========================================
+ Coverage   79.19%   80.29%   +1.09%     
==========================================
  Files         251      251              
  Lines       21993    22154     +161     
  Branches     2683     2745      +62     
==========================================
+ Hits        17418    17788     +370     
+ Misses       4531     4322     -209     
  Partials       44       44              
Files Changed Coverage Δ
packages/rax-compat/src/create-class.ts 96.12% <96.06%> (-3.88%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@wssgcg1213 wssgcg1213 merged commit b70bba1 into master Sep 11, 2023
6 checks passed
@wssgcg1213 wssgcg1213 deleted the refactor/rax-compat branch September 11, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants