Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rax-compat): fix createElement runtime import #6814

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(rax-compat): fix createElement runtime import #6814

merged 1 commit into from
Mar 11, 2024

Conversation

linbudu599
Copy link
Collaborator

修正了在特定情况下，swc 的转换代码会进行如下的代码转换：

import Rax from 'rax-compat';

import { createElement } from 'rax-compat/runtime';

这个PR 为 rax-compat 提供了 /runtime 的 subpath。

@linbudu599 linbudu599 changed the base branch from master to release/next February 28, 2024 09:05
@linbudu599 linbudu599 added the need review Need Review label Feb 28, 2024
ClarkXia
ClarkXia previously approved these changes Feb 29, 2024
View reviewed changes
Base automatically changed from release/next to master March 7, 2024 05:26
@ClarkXia ClarkXia dismissed their stale review March 7, 2024 05:26

The base branch was changed.

@ClarkXia ClarkXia changed the base branch from master to release/next March 7, 2024 07:44
@ClarkXia ClarkXia merged commit 886c4de into release/next Mar 11, 2024
7 checks passed
@ClarkXia ClarkXia deleted the fix/fix_createElement_runtime branch March 11, 2024 03:18
@ClarkXia ClarkXia mentioned this pull request Mar 19, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClarkXia ClarkXia ClarkXia approved these changes

@wssgcg1213 wssgcg1213 Awaiting requested review from wssgcg1213

Assignees
No one assigned
Labels
need review Need Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linbudu599 @ClarkXia