Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support split page chunk in cjs format #6843

Merged
merged 6 commits into from
May 6, 2024

Conversation

ClarkXia
Copy link
Collaborator

Relate to #6842

@ClarkXia ClarkXia changed the base branch from master to release/next March 27, 2024 11:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 57.35294% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 78.92%. Comparing base (ea7d71e) to head (61e0b46).

Files Patch % Lines
packages/ice/src/utils/multipleEntry.ts 41.07% 33 Missing ⚠️
packages/ice/src/utils/getEntryPoints.ts 35.29% 11 Missing ⚠️
packages/ice/src/createService.ts 40.00% 9 Missing ⚠️
packages/ice/src/routes.ts 84.21% 3 Missing ⚠️
packages/ice/src/bundler/config/plugins.ts 87.50% 1 Missing ⚠️
packages/ice/src/utils/generateEntry.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/next    #6843      +/-   ##
================================================
- Coverage         79.08%   78.92%   -0.16%     
================================================
  Files               221      223       +2     
  Lines             19715    19842     +127     
  Branches           2506     2515       +9     
================================================
+ Hits              15592    15661      +69     
- Misses             4085     4143      +58     
  Partials             38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia changed the title [WIP] feat: support spilt page chunk in cjs format feat: support spilt page chunk in cjs format Mar 28, 2024
@ClarkXia ClarkXia changed the title feat: support spilt page chunk in cjs format feat: support split page chunk in cjs format Mar 29, 2024
@ClarkXia ClarkXia requested a review from luhc228 April 2, 2024 03:34
@ClarkXia ClarkXia added the need review Need Review label Apr 9, 2024
luhc228
luhc228 previously approved these changes Apr 10, 2024
luhc228
luhc228 previously approved these changes Apr 10, 2024
@ClarkXia ClarkXia removed the need review Need Review label Apr 10, 2024
Base automatically changed from release/next to master April 22, 2024 06:14
@ClarkXia ClarkXia dismissed luhc228’s stale review April 22, 2024 06:14

The base branch was changed.

@ClarkXia ClarkXia changed the base branch from master to release/next April 22, 2024 06:42
@ClarkXia ClarkXia requested a review from luhc228 May 6, 2024 01:56
@ClarkXia ClarkXia added the need review Need Review label May 6, 2024
@ClarkXia ClarkXia merged commit 11a87dc into release/next May 6, 2024
7 checks passed
@ClarkXia ClarkXia deleted the feat/server-chunk branch May 6, 2024 09:22
@ClarkXia ClarkXia mentioned this pull request May 7, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants