Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: optimize runtime code when dataLoader is not defined #6849

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Apr 1, 2024

The dataLoader runtime is unnecessary when dataLoader is not exported.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/next@ee14962). Click here to learn what that means.

Files Patch % Lines
packages/runtime/src/appData.ts 80.00% 2 Missing ⚠️
packages/runtime/src/runClientApp.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/next    #6849   +/-   ##
===============================================
  Coverage                ?   79.11%           
===============================================
  Files                   ?      221           
  Lines                   ?    19745           
  Branches                ?     2508           
===============================================
  Hits                    ?    15622           
  Misses                  ?     4086           
  Partials                ?       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia requested a review from luhc228 April 2, 2024 03:32
@ClarkXia ClarkXia added the need review Need Review label Apr 9, 2024
@ClarkXia ClarkXia merged commit 77155ba into release/next Apr 9, 2024
7 checks passed
@ClarkXia ClarkXia deleted the feat/data-loader branch April 9, 2024 08:26
@ClarkXia ClarkXia mentioned this pull request Apr 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants