Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clean code] dependency javatuple is unused #11975

Closed
shalk opened this issue Apr 18, 2024 · 0 comments · Fixed by #11976
Closed

[clean code] dependency javatuple is unused #11975

shalk opened this issue Apr 18, 2024 · 0 comments · Fixed by #11976
Labels
dependencies Pull requests that update a dependency file kind/enhancement Category issues or prs related to enhancement.

Comments

@shalk
Copy link
Contributor

shalk commented Apr 18, 2024 •
edited
Loading

Describe the bug

Dependency org.javatuple is dependency in 3 modules consistency naming and core.

Only class Pair of org.javatuple is used in consistency/src/main/java/com/alibaba/nacos/consistency/ProtocolMetaData.java

The method public Map<String, Map<Object, Object>> getMetaDataMap() use the pair.

We can replace it with com.alibaba.nacos.common.utils.Pair;

Expected behavior
not contains depdency javatuple

Actually behavior
contains depdency javatuple
@shalk shalk mentioned this issue Apr 18, 2024
Merged
5 tasks
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. dependencies Pull requests that update a dependency file labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#11975] clean code , remove unused dependency javatuple shalk/nacos
2 participants
@shalk @KomachiSion