Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilation error: tengine-2.2.3 does not support google/ngx_brotli #1198

Closed
cnrting opened this issue Mar 4, 2019 · 8 comments
Closed

compilation error: tengine-2.2.3 does not support google/ngx_brotli #1198

cnrting opened this issue Mar 4, 2019 · 8 comments

Comments

@cnrting
Copy link

cnrting commented Mar 4, 2019

adding module in /root/tengine-2.2.3/modules/ngx_brotli
./configure: error: Brotli module requires recent version of NGINX (1.9.11+).

build on Linux ae2a 3.10.0-957.1.3.el7.x86_64

@wangfakang
Copy link
Collaborator

@cnrting Because the Brotli module relies on the Nginx core version, you could try to Tengine master branch Note: which has been upgraded to Nginx official 1.15.9 . Please refer to #1196 for more details.

@chobits
Copy link
Member

chobits commented Mar 5, 2019

hi @cnrting

Can it work with Tengine latest master branch?

@chobits
Copy link
Member

chobits commented Mar 5, 2019

 We have checked lastest master branch, it can work. Please check it. I'm closing this issue.

Feel free to reopen if you have any problem.

@chobits chobits closed this as completed Mar 5, 2019
@cnrting
Copy link
Author

cnrting commented Mar 5, 2019

hello @chobits ,branch version is still 2.2.2?! not 2.2.3?

[root@ae2a tengine]# nginx -V
Tengine version: Tengine/2.2.2 (nginx/1.15.9)
built by gcc 4.8.5 20150623 (Red Hat 4.8.5-36) (GCC)
built with OpenSSL 1.0.2k-fips 26 Jan 2017
TLS SNI support enabled
configure arguments: --with-http_realip_module --with-http_v2_module --add-module=/root/tengine/modules/ngx_brotli --add-module=/root/tengine-2.2.3/modules/headers-more-nginx-module-0.33

@chobits chobits changed the title wtf?not supporting ngx_brotli?it's 2019! compilation error: tengine-2.2.3 does not support google/ngx_brotli Mar 6, 2019
@chobits
Copy link
Member

chobits commented Mar 6, 2019

hi @cnrting

hello @chobits ,branch version is still 2.2.2?! not 2.2.3?

It doesn’t matter.

We still have a new feature to add tengine 2.3.x. On completion of all features merged, we'll add commit to bump version to 2.3.x.

@meilihao
Copy link

Use https://github.com/eustas/ngx_brotli with Tengine-2.3.1 is ok:

$ ./nginx -V
Tengine version: Tengine/2.3.1
nginx version: nginx/1.16.0
built by gcc 9.1.0 (GCC) 
built with OpenSSL 1.1.0j  20 Nov 2018
TLS SNI support enabled
configure arguments: --with-cc=/usr/local/gcc-9.1/bin/gcc-9.1 --with-jemalloc=/home/chen/test/jemalloc-5.2.0 --add-module=/home/chen/test/ngx_brotli

brotli's version is to 78e7bbc.

resp:

HTTP/1.1 200 OK
Server: Tengine/2.3.1
Date: Wed, 10 Jul 2019 07:22:49 GMT
Content-Type: text/html
Last-Modified: Wed, 10 Jul 2019 06:56:21 GMT
Transfer-Encoding: chunked
Connection: keep-alive
ETag: W/"5d258c15-22b"
Content-Encoding: br

@meilihao
Copy link

@chobits
Copy link
Member

chobits commented Jul 10, 2019

By the way: google/ngx_brotli is dead and eustas is primary contributor to google/brotli.

Thank you for letting us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants