Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: incorrect index calculation for "bottom-right to up-left" scan in void Texturing::generateTexturesSubSet(...) #644

Closed
ChaoJia opened this issue Jun 8, 2019 · 2 comments · Fixed by #629

Comments

@ChaoJia
Copy link
Contributor

ChaoJia commented Jun 8, 2019

Got Abnormal program termination: received signal 11 (SIGSEGV) in step [11/11] Texturing.

I built and compiled AliceVision with vcpkg and VS 2017 (15.9.12) under Windows 10 from the lastest commit in develop branch (commit 132ac39), and ran the photogrammetry pipeline through python bin/meshroom_photogrammetry.

dataset_monstree/mini3 was used.

After changing

617 unsigned int yoffset = (outTextureSide - y) * outTextureSide;
...
620     unsigned int xyoffset = yoffset + (outTextureSide - x);

to

617 unsigned int yoffset = (outTextureSide - y - 1) * outTextureSide;
...
620     unsigned int xyoffset = yoffset + (outTextureSide - x - 1);

in file ${AliceVision_root}/src/aliceVision/mesh/Texturing.cpp, the problem went away, and the generated texture seems to be correct.

@fabiencastan
Copy link
Member

Thanks for the report and the analysis!
We are aware of it and we are about to merge the PR #629 in the coming days which already fixes this issue (and contains texturing improvements).

@ChaoJia
Copy link
Contributor Author

ChaoJia commented Jun 8, 2019

Thanks!

@ChaoJia ChaoJia closed this as completed Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants