Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module imports not working properly in refactored code #141

Closed
alichtman opened this issue Oct 25, 2018 · 0 comments
Closed

Module imports not working properly in refactored code #141

alichtman opened this issue Oct 25, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@alichtman
Copy link
Owner

alichtman commented Oct 25, 2018

I had an import statement in one of the files that was pulling from a locally installed version of shallow-backup, so all of this code worked on my laptop, but would crash unless you happen to have a shallow-backup binary installed.

In looking at it now, I don't really understand why this doesn't work. I'll look into this more soon...

Also, our testing suite needs to include more shallow-backup functionality, not just utility testing. The suite shouldn't pass this build.

image

@alichtman alichtman added the bug Something isn't working label Oct 25, 2018
@alichtman alichtman changed the title Master is broken. No init functions in any of the refactored code Oct 25, 2018
@alichtman alichtman changed the title No init functions in any of the refactored code Need init functions in all of the refactored code Oct 25, 2018
@alichtman alichtman changed the title Need init functions in all of the refactored code Module imports not working properly in refactored code Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant