Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting backup path to ~/.shallow_backup breaks subsequent runs #265

Closed
ThatsJustCheesy opened this issue Apr 22, 2020 · 1 comment · Fixed by #267
Closed

Setting backup path to ~/.shallow_backup breaks subsequent runs #265

ThatsJustCheesy opened this issue Apr 22, 2020 · 1 comment · Fixed by #267
Labels
bug Something isn't working

Comments

@ThatsJustCheesy
Copy link
Contributor

I wanted my backup to be hidden, so I innocuously specified ~/.shallow-backup as my backup dir. The first backup ran fine, but subsequent runs spit out this message that explains the "what" but not the "why":

ERROR: /Users/ian/.shallow-backup is a directory, when we were expecting a file. Manual intervention is required.

This is apparently triggered by config file migration. If this code needs to remain for the forseeable future, then ~/.shallow-backup should probably be forbidden as a backup path.

@alichtman
Copy link
Owner

alichtman commented Apr 23, 2020

Yep, this seems like an unintended consequence of the config file migration.

I think that removing this set of lines will solve the problem without causing any other side effects:

elif os.path.isdir(old_config_path):
print_red_bold(f"ERROR: {old_config_path} is a directory, when we were expecting a file. Manual intervention is required.")
sys.exit(1)

Would you like to put up a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants