Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Suite #69

Closed
alichtman opened this issue Oct 14, 2018 · 4 comments
Closed

Testing Suite #69

alichtman opened this issue Oct 14, 2018 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing

Comments

@alichtman
Copy link
Owner

A testing suite would be great to have here.

It should test all basic functionality, and make sure all files are backed up correctly.

I'd like to use pytest for testing.
@alichtman alichtman added help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest testing labels Oct 14, 2018
@jasikpark
Copy link
Contributor

jasikpark commented Oct 15, 2018 •
edited
Loading

Apparently Travis CI is problematic if you specifically want to run python tests with macOS. http://blog.fizyk.net.pl/blog/running-python-tests-on-traviss-osx-workers.html

@alichtman
Copy link
Owner Author

Maybe we can explore other CI services? I'll look into this further when I have time.

@mynamewastaken mynamewastaken mentioned this issue Oct 15, 2018
Closed
@pyasi pyasi mentioned this issue Oct 18, 2018
Merged
@pyasi
Copy link
Contributor

pyasi commented Oct 18, 2018

Put up a PR to start this off. Happy for feedback on my approach/suggestions for more testing.

@alichtman
Copy link
Owner Author

Just gave it a look -- great work, @pyasi! Leaving some feedback for you, and then we can get it merged in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pyasi @jasikpark @alichtman