fix: ensure node-test-commit job id in daily-master (#460)

* fix: get node-test-commit job id * chore: remove unused setDailyBuildData
johnfrench3 · Jul 21, 2020 · 056cc8e · 056cc8e
1 parent 379317d
commit 056cc8e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/bin/ncu-ci b/bin/ncu-ci
@@ -239,8 +239,15 @@ class CICommand {
         case DAILY_MASTER: {
           const daily = new DailyBuild(cli, request, job.jobid);
           const data = await daily.getBuildData();
-          build = new CommitBuild(cli, request, data.subBuilds[0].buildNumber);
-          break;
+          const testCommitBuild = data.subBuilds.filter(subBuild => {
+            return subBuild.jobName === 'node-test-commit';
+          })[0];
+          if (testCommitBuild) {
+            build = new CommitBuild(cli, request, testCommitBuild.buildNumber);
+            break;
+          } else {
+            throw new Error('Could not find \'node-test-commit\' job');
+          }
         }
         default:
           throw new Error(`Unknown job type ${job.type}`);

diff --git a/lib/ci/ci_result_parser.js b/lib/ci/ci_result_parser.js
@@ -225,13 +225,6 @@ class TestBuild extends Job {
     this.builtOn = builtOn;
   }
 
-  setDailyBuildData({ result, changeSet, actions, timestamp, builtOn }) {
-    this.change = changeSet.items[0] || {};
-    this.date = new Date(timestamp);
-    this.result = result;
-    this.builtOn = builtOn;
-  }
-
   get sourceURL() {
     const { params } = this;