Skip to content

Commit

Permalink
fix(update-v8): force-add all files after cloning V8 (#549)
Browse files Browse the repository at this point in the history
Add all V8 files with --force before updating DEPS. We have to do this
because some files are checked in by V8 despite .gitignore rules.
  • Loading branch information
Alicia Lopez committed Jul 3, 2021
1 parent ed71b61 commit 2d3704b
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions lib/update-v8/majorUpdate.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = function() {
removeDepsV8(),
cloneLocalV8(),
removeDepsV8Git(),
addDepsV8(),
updateV8Deps(),
applyNodeChanges()
]);
Expand Down Expand Up @@ -96,6 +97,17 @@ function removeDepsV8Git() {
};
}

function addDepsV8() {
return {
title: 'Track all files in deps/v8',
// Add all V8 files with --force before updating DEPS. We have to do this
// because some files are checked in by V8 despite .gitignore rules.
task: (ctx) => execa('git', ['add', '--force', 'deps/v8'], {
cwd: ctx.nodeDir
})
};
}

function updateV8Deps() {
return {
title: 'Update V8 DEPS',
Expand Down

0 comments on commit 2d3704b

Please sign in to comment.