Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pearcleaner selects uncorrect files #170

Closed
L1cardo opened this issue Nov 28, 2024 · 3 comments
Closed

[BUG] Pearcleaner selects uncorrect files #170

L1cardo opened this issue Nov 28, 2024 · 3 comments

Comments

@L1cardo
Copy link
Contributor

L1cardo commented Nov 28, 2024

Describe the bug:

Pearcleaner selects uncorrect files that is not related to the app

Steps to reproduce:

  1. Uninstall app that is in a folder from finder extension

Info:

  • OS: [macOS 15.1.1]
  • Pearcleaner Version: [v4.0.1]

Screenshots:

image
https://github.com/user-attachments/assets/3afee042-ff2c-48ff-8d4b-69411512da48

Console Logs (For app crashes or hard to reproduce issues):

  1. Open the Terminal app and run the following command
log stream --level debug --style compact --predicate 'subsystem == "com.alienator88.Pearcleaner"'

image

@alienator88
Copy link
Owner

I think the issue here is the bundle id under the app's name FinalShell is just "st".
Is that the valid bundle id of that app if you look at the Info.plist file?
It's doing a search on the bundle id and "st" matches a lot of those files in the list
Pastepal
SpeedTest
etc..

@alienator88
Copy link
Owner

I just found it and installed it from brew, yeah the bundle id really is that short.
Not sure what the dev was doing there 😂
I can probably add a catch that if the bundle id is less than 2 components long, to fallback to app name search only.

@alienator88
Copy link
Owner

Okay, just got this fixed.
I decided to go with checking if the bundle id is one component only, like FinalShell, then check to make sure the length of the bundle id is at least 5 characters long to prevent these scenarios where very short ids find unrelated files.
Now it only finds 2 files as expected.
Thanks for finding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants