-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] App size in app list (+sort option) #62
Comments
I have built this in now, but I'm playing around with a few things. I will try to find a way to calculate the sizes faster as first step. This is what it looks like, hovering over an app shows the app version still: |
It looks awesome! Thank you so much! Do you plan to have option to sort by size as well?
Hmmm. I'm more than fine with having it behind (off by default) option. Alas, have you considered updating it lazily? Open the app, show the list and then in background thread calculate the sizes (and having "update progress" icon instead of size while the calculcation takes place on each row)? |
The sorting is already there, just no icon for it. Clicking the User or System headers flips to alphabetical or size sorting. So lazy loading was one of the options I was playing with(my top choice currently), only thing I'm stuck on is say you have the sorting set to size on app load. If each item doesn't have sizes yet, how would the sorting behave? Default to alphabetical? But then once the sizes are fully loaded, the items would all move around to get in the right size sorting order. It seems jarring to the end-user experience. Another idea(2nd choice) I had was maybe cache the app list data like app name, icon, version and size via core data. These shouldn't change very often at all. Then on launch, load everything from the cache and process any new apps that might not be already in there and add those to the cache as well. Also refresh these cached apps if it's been longer than 7 days to keep details updated. I'm not sure yet what direction to go with, but I do know I don't think I want that loading delay on app launch. So will need to figure something out 😄 |
Give this a try and let me know what you think of the delay, maybe I'm overthinking it. For me, I have about 50 apps installed and it takes me 2-3 seconds to fully load in. |
I think that defaulting to sorting by App name by default is fine. Though the list could be updated dynamically. I'm using Doughnut podcast player and in there the default sort is by the number of new (unplayed) episodes. When the app starts (or if the update happens) then the list is just sorted/updated. It's not that jarring in the end. I checked the attached app and it works great. With about 130 apps it took a couple of seconds but it's not a problem (for me at least) :-) |
Do you see any performance increase on this version? I changed the thread it runs on from .background to .userInitiated which should increase the speed and also fixed some UI choppiness when loading the apps. |
Scratch that last update, I think I got the lazy loading working really good now. It's pretty much instant in my testing. |
Pushed v3.7.0 out with this feature. |
Just updated via homebrew and works perfectly. Thank you so much! |
Hi, so this is by design actually. When you click on an app in the sidebar, that's when Pearcleaner performs the actual file search and computes all the values. I didn't want to show the size of the app and all related files in the sidebar for a couple reasons:
Since the sidebar holds the list of apps themselves, I thought it made sense to show the app's own size instead. The detail view on the right side is where all the found files and their sizes are shown. To me, these sizes seemed unrelated compared to the sidebar's function, which is just to show the app list and that's it. I hope this makes sense! |
Fair enough :-) One thing though:
Wouldn't this cause issues with the deletion process in itself? |
In what way do you mean? |
Yes, user is presented but a lot of users probably is not aware that something "may not be related" thus clicking "Delete" without even looking at the list. |
IMHO sounds reasonable :-) |
Sweet, I'll add that to the next update :) |
Looks good! 👍 |
Is your feature request related to a problem? Please describe.
When I cleanup my machine I often like to remove "big apps" that I may not be using. Having appsize (+option to sort apps by size) would help with that
Describe the solution you'd like
Display app-size in the list next to a version (or instead?) with option to sort by it would be great.
The text was updated successfully, but these errors were encountered: