Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickbase #5

Open
wants to merge 173 commits into
base: demo-clickhouse-k8s
Choose a base branch
from
Open

Clickbase #5

wants to merge 173 commits into from

Conversation

alisman
Copy link
Owner

@alisman alisman commented Mar 8, 2024

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • a
  • b

Checks

  • Runs on heroku
  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

jagnathan and others added 30 commits December 2, 2022 12:23
- modified java files to remove unused properties and changes to tests
- db changes, mutationmapper.xml
- Update seed_mini.sql

roll back changes for refseqMrnaId

roll back changes for refseqMrnaId

Update ExtendedMutation.java

Added required property setOncotatorRefseqMrnaId and getOncotatorRefseqMrnaId
Updated more files for removed fields

Remove unused oncotator fields

Remove unused oncotator fields
ONCOTATOR_DBSNP_RS
ONCOTATOR_UNIPROT_ENTRY_NAME

remove fields from sql file

ONCOTATOR_DBSNP_RS and ONCOTATOR_UNIPROT_ENTRY_NAME removal from sql file
db changes in sql for renaming columns
renamed the column prefixes from oncotator to mutation on multiple classes and files
Update testSql.sql

updating testSql for the name change of columns from ONCOTATOR to MUTATION

Update DaoMutation.java

The data files still use the old column prefix of ONCOTATOR instead of MUTATION

Update DaoMutation.java

Update migration.sql

Adding quotes around column names
db changes in sql for renaming columns
renamed the column prefixes from oncotator to mutation on multiple classes and files
Update migration.sql

fix syntax errors in mysql change column

Update migration.sql

fix syntax errors in mysql change column

setting db version

setting db version
Removed Link columns and modified the documentation
…api-endpoint-final

Fix 9461 mutations api endpoint final
…d support for multiple database impls to support mysql and h2
…patible-with-sqlmodeOnlyFullGroupBy

Update SQL to fix incompatibility with sqlmode OnlyFullGroupBy
We need to update this test because it's not java 8 compatible.
update cosmic importer for new cosmic datafiles
dippindots and others added 30 commits July 18, 2023 15:25
See yaml/pyyaml#724 for details of this update
Set download button visibility in UI based on user role/group
Allow Redis service unavailable when Redis is enabled
* Add two-sided fisher tests news

---------

Co-authored-by: Ino de Bruijn <ino@ino.bio>
* implement getting CNA types for a gene specific

* add tests for genomic-data-counts endpoint

* change CopyNumberDataCounterFilter to StudyViewFilter and GenomicDataCountFilter

* change to molecularDataService to fetch data

* add filter logic for DISCRETE molecular profiles

* Refactor

* count NA and clean up codes

* Updates

* Update StudyViewServiceImplTest.java

---------

Co-authored-by: Qi-Xuan Lu <qlu@carisls.com>
Co-authored-by: Karthik <kalletlakarthik@gmail.com>
)

* Add defaults for mutation heatmap and line chart checkboxes

* Update text

---------

Co-authored-by: Gaofei Zhao <15748980+dippindots@users.noreply.github.com>
* Add data access token user role filter feature
* Update and more tests
* Update failing test

---------

Co-authored-by: Jeremy R. Easton-Marks <j.r.eastonmarks@gmail.com>
Add label check test for pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.