Universal import support #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof, this may break default import behavior (in Typescript at least). This worked before: import CancelablePromise from 'cancelable-promise';
CancelablePromise.cancelableBut after this PR, it throws: This is likely a breaking change then. |
|
@claabs is this PR mergable now? I have multiple issues with this lib in heterogenous workspace (used from CommonJS and ESM). This PR might solve all of those. |
I don't have the highest confidence. For my project, I ended up switching to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully address the hell that is universal compatibility across all JS ecosystems, versions, and bundlers.
Resolves #940
Here's a bunch of resources that I utilized to come to this solution:
.d.mtsTo verify the exports are okay, I ran
All turned up with no problems.
I tested with ESM Node and Typescript, but CJS Node and browser imports should be tested to ensure no breaking changes.