Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[risk=low][RW-13725] remove getUploadResult in verifyAndLog #8955

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

Qi77Qi
Copy link
Contributor

@Qi77Qi Qi77Qi commented Nov 19, 2024

getUploadResult for leonardoAppUsage table isn't needed because verifyAndLog isn't used for validating batch results. verifyBatchesAndLog is validating leonardoAppUsage already

When I was testing locally, I commented out the non batch uploads, which is why I didn't catch this locally

Tested locally with everything enabled and works as expected

PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

@Qi77Qi Qi77Qi requested a review from yonghaoy November 19, 2024 16:12
@jmthibault79
Copy link
Collaborator

Could you add a comment or two in the code explaining why we don't follow the usual pattern here?

@Qi77Qi Qi77Qi merged commit 1f7ca68 into main Nov 19, 2024
7 checks passed
@Qi77Qi Qi77Qi deleted the qiBugFix branch November 19, 2024 17:46
@Qi77Qi
Copy link
Contributor Author

Qi77Qi commented Nov 19, 2024

@jmthibault79 it is existing pattern. It's just there're two patterns. One for taking an entire snapshot, and the other is using batches. Reporting LeonardoAppUsage was uploading entire dataset previously, and my previous PR changed it to use batches, but missed this reporting part which is still using the snapshot pattern

evrii pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants