Fix python-fire integration (issue #/1268) #1275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue \ discussion
Check #1268
Patch Description
ClearML reassignes python-fire function
_CallAndUpdateTrace
with the_patched_call
wrapper call result. The first argument of_patched_call
is_CallAndUpdateTrace
itself and the second is__CallAndUpdateTrace
from ClearML.In the end, original function is passed to the
__CallAndUpdateTrace
with all its arguments.Original function sets the default value for
target
argument asNone
. So it could be successfully called without passing this argument explicitly (done there).But when it comes to
__CallAndUpdateTrace
in ClearML - there is no default value fortarget
. So it throws an error of missing positional argument as I mentioned in #1268Testing Instructions
Code example given in the related issue is enough for testing this behaviour.