Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python-fire integration (issue #/1268) #1275

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

tvelovraf
Copy link
Contributor

Related Issue \ discussion

Check #1268

Patch Description

ClearML reassignes python-fire function _CallAndUpdateTrace with the _patched_call wrapper call result. The first argument of _patched_call is _CallAndUpdateTrace itself and the second is __CallAndUpdateTrace from ClearML.
In the end, original function is passed to the __CallAndUpdateTrace with all its arguments.

Original function sets the default value for target argument as None. So it could be successfully called without passing this argument explicitly (done there).
But when it comes to __CallAndUpdateTrace in ClearML - there is no default value for target. So it throws an error of missing positional argument as I mentioned in #1268

Testing Instructions

Code example given in the related issue is enough for testing this behaviour.

Fixes bug when calling `__call__` method of a class via Fire
@jkhenning jkhenning merged commit 22bbb66 into allegroai:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants