New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release lock after dataset cache is downloaded #708

Merged

jkhenning merged 2 commits into allegroai:master from mralgos:master

Jul 13, 2022

Contributor

mralgos commented Jul 5, 2022

Ref: #671

Basically, two main changes:

once the download of a dataset is completed, the lock is released immediately
while a process is downloading a dataset i.e. holding the lock, other processes will wait until the lock is released (in the current fix, after 5 min of wait there's a timeout error raise. But this can be changed)

mralgos added 2 commits

June 3, 2022 16:47


          Possible fix to dataset cache locks (allegroai#671)

895183e


          Removed unnecessary additional return (allegroai#671)

355ecd4

jkhenning merged commit 397dcfa into allegroai:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet