840: Set GCS credentials to None if invalid service account creds provided #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue \ discussion
#840
https://clearml.slack.com/archives/CTK20V944/p1669932989917539
Patch Description
If an invalid a non service account credentials json is provided to the credentials, the GCS client will fail to be created, this happens when developing locally.
When passing
credentials=None
tostorage.Client()
it will fetch the environment variableGOOGLE_APPLICATION_CREDENTIALS
as they recommend.The original bug most likely stems from
bucket_config.py
setting the credentials via the global variable described above.Testing Instructions
Other Information