Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

840: Set GCS credentials to None if invalid service account creds provided #841

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

freddessert
Copy link
Contributor

@freddessert freddessert commented Dec 2, 2022

Related Issue \ discussion

#840
https://clearml.slack.com/archives/CTK20V944/p1669932989917539

Patch Description

If an invalid a non service account credentials json is provided to the credentials, the GCS client will fail to be created, this happens when developing locally.
When passing credentials=None to storage.Client() it will fetch the environment variable GOOGLE_APPLICATION_CREDENTIALS as they recommend.
The original bug most likely stems from bucket_config.py setting the credentials via the global variable described above.

Testing Instructions

  1. Authenticate your local Google Cloud environment as described in the Google Documentation.
  2. Create a ClearML Dataset with an output_uri set to a GCS bucket location you have access to.
  3. The ClearML Dataset is successfully created.

Other Information

@jkhenning jkhenning merged commit 911a72f into allegroai:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants