Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

MLM in AllenNLP? #5089

Open
ethch18 opened this issue Apr 2, 2021 · 4 comments
Open

MLM in AllenNLP? #5089

ethch18 opened this issue Apr 2, 2021 · 4 comments

Comments

@ethch18
Copy link

ethch18 commented Apr 2, 2021

Hi! I saw that there's currently a masked language modeling Model over in the allennlp-models repo, but it looks like most of the components are marked as demo-only. Is full functionality for this on the roadmap? If not, is there an estimate of what it would take to get it working?

@epwalsh
Copy link
Member

epwalsh commented Apr 9, 2021

Hey @ethch18, this model was developed without the intent of making it efficient for training. And it's not on our road-map to improve this class, but we would certainly appreciate contributions.

I'm not sure how much work this would take, as this implementation is pretty old at this point and I'm not very familiar with it. But I'm happy to try to answer specific questions that arise.

@ethch18
Copy link
Author

ethch18 commented Apr 12, 2021

Thanks @epwalsh, I'll think about this more. I won't be able to work on it immediately, but I can leave the issue open in case others want to take on it

@JohnGiorgi
Copy link
Contributor

JohnGiorgi commented May 1, 2021

@ethch18 I implemented MLM in AllenNLP for my own project. Unfortunately its highly coupled to some other code, but these might be useful:

Hope that helps!

@ethch18
Copy link
Author

ethch18 commented May 1, 2021

@JohnGiorgi thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants