This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
pin msgpack #2125
Merged
pin msgpack #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmmd
approved these changes
Nov 30, 2018
|
Sorry about this. I've released Thinc v6.12.1 so installations should work correctly. spaCy avoids depending on msgpack directly for just this sort of reason, it's imported via Thinc --- so we only need to change it there. Btw, your spaCy pin is correct. You've got it pinned to >=2.0,<2.1, which is right. The current stable is v2.0. We only have v2.1 on |
nelson-liu
added a commit
to allenai/allennlp-feedstock
that referenced
this pull request
Dec 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this will fix
explosion/spaCy#2995
(we are pinned to an old version of spacy, which is pinned to an old version of thinc, so we don't get the fix just by updating)