From 5d948085b9c922ef0ca6947155436fa8264a8f93 Mon Sep 17 00:00:00 2001 From: Michael Schmitz Date: Thu, 21 Dec 2017 08:21:42 -0800 Subject: [PATCH 1/3] Move jupyter dependency to requirements_test. --- requirements.txt | 3 --- requirements_test.txt | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/requirements.txt b/requirements.txt index 15d074482d1..c2731847239 100644 --- a/requirements.txt +++ b/requirements.txt @@ -58,9 +58,6 @@ tqdm # In SQuAD eval script, we use this to see if we likely have some tokenization problem. editdistance -# Tutorial notebooks -jupyter - # For pretrained model weights h5py diff --git a/requirements_test.txt b/requirements_test.txt index 89eafbf6817..2e5ce1b9403 100644 --- a/requirements_test.txt +++ b/requirements_test.txt @@ -7,6 +7,9 @@ pylint==1.8.1 # the tests. With this here, you can run the tests with `py.test` from the base directory. pytest +# Tutorial notebooks +jupyter + # Static type checking mypy From 953e779ef5901f39546d8578d9228bbd34027c69 Mon Sep 17 00:00:00 2001 From: Michael Schmitz Date: Thu, 21 Dec 2017 09:40:44 -0800 Subject: [PATCH 2/3] Remove Jupyter from setup.py. --- setup.py | 1 - 1 file changed, 1 deletion(-) diff --git a/setup.py b/setup.py index c0182a01a45..c658000cd46 100644 --- a/setup.py +++ b/setup.py @@ -101,7 +101,6 @@ 'requests>=2.18', 'tqdm', 'editdistance', - 'jupyter', 'h5py', 'scikit-learn', 'scipy', From 087df5a7ed00c749e8d4c0a7b4bdeabd59a85650 Mon Sep 17 00:00:00 2001 From: Michael Schmitz Date: Thu, 21 Dec 2017 10:52:30 -0800 Subject: [PATCH 3/3] Add installing Jupyter to the notebook instructions. --- tutorials/notebooks/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tutorials/notebooks/README.md b/tutorials/notebooks/README.md index a22fe6a1258..c37b55fb64b 100644 --- a/tutorials/notebooks/README.md +++ b/tutorials/notebooks/README.md @@ -11,8 +11,8 @@ library. We recommend that you walk through them in the following order: 4. `Trainers`, `Models` and `Drivers` 5. Running experiments from JSON with AllenNLP. - -To load a tutorial, follow the [install instructions](../../README.md) and then launch Jupyter. +To load a tutorial, follow the [install instructions](../../README.md) and install Jupyter +(`pip install jupyter`). Then you can launch Jupyter with the following. ```jupyter notebook```