Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROS 2 parameters and use node's clock instance #9

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

allenh1
Copy link
Owner

@allenh1 allenh1 commented Apr 24, 2020

Signed-off-by: Hunter L. Allen hunter.allen@ghostrobotics.io

Fixes #8


@Bert-Tec / @adamkrawczyk Could you please test

ros2 launch rplidar_ros rplidar_s1.launch.py

for me? I do not have that laser.

Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
@allenh1 allenh1 added bug Something isn't working enhancement New feature or request labels Apr 24, 2020
@allenh1 allenh1 self-assigned this Apr 24, 2020
allenh1 added 2 commits April 27, 2020 11:18
Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
@allenh1 allenh1 merged commit 608ce9d into ros2 Apr 27, 2020
@allenh1 allenh1 deleted the 8-fix-rplidar-s1-timeout branch April 27, 2020 15:22
bednarhonza pushed a commit to fly4future/rplidar_ros2 that referenced this pull request Jun 7, 2022
Use galactic as default build env, remove foxy from deb task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rplidar_s1 operation timeout
1 participant