Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mastodon link to social footer #185

Closed
vielmetti opened this issue Dec 24, 2023 · 11 comments
Closed

Add Mastodon link to social footer #185

vielmetti opened this issue Dec 24, 2023 · 11 comments

Comments

@vielmetti
Copy link
Collaborator

The Mastodon link at @aha@a2mi.social is omitted from the bottom footer on the main page of the site.

@vielmetti
Copy link
Collaborator Author

Looks like one piece of this is adding an icon, which is at

links:

fontawesome has this icon at https://fontawesome.com/icons/mastodon?f=brands&s=solid

@artlogic
Copy link
Collaborator

Good catch @vielmetti - any chance you feel up to creating a PR for this?

@vielmetti
Copy link
Collaborator Author

@artlogic I can try a PR. What version of Font Awesome are we using? I can't figure out where that gets pulled in. And do we have a test system where I can see what the PR looks like?

@artlogic
Copy link
Collaborator

It's being pulled in from the parent theme: https://mmistakes.github.io/minimal-mistakes/

Remote PRs don't get built on the test system, but local ones do. I'll get you access to this repo so you can take advantage of that.

@vielmetti
Copy link
Collaborator Author

Let's do #182 (update minimal-mistakes) first -- the change log for that suggests some changes to font awesome.

@artlogic
Copy link
Collaborator

All ready for you @vielmetti

@vielmetti
Copy link
Collaborator Author

Some looking at this:

Since the latest release of Minimal Mistakes, Font Awesome has made some changes. It looks like there are unreleased bits that track those changes, e.g. at mmistakes/minimal-mistakes#3599 .

The Mastodon icon was introduced in Font Awesome 5.8.0: FortAwesome/Font-Awesome#17980

I was able to put together a patch that added the link, but didn't add the icon. I'll get that as a PR to review, but I don't think it will be ready to merge just yet.

@vielmetti
Copy link
Collaborator Author

I got the link into the footer in #186 but I'm puzzled by Font Awesome, and several attempts to load the glyph (which is supported only in FA 5.8.0) haven't worked.

@artlogic
Copy link
Collaborator

@SKBruck any insight here?

@SKBruck
Copy link
Collaborator

SKBruck commented Dec 25, 2023

I can try to get minimal mistakes updated and see if that will resolve issues. I had run into an issue updating which is why it hasn't been pushed as a pr yet. I'm wrapping gifts so I'll look at what's up again and try to get a PR pushed tomorrow after family stuff. I can't currently add details because I'm afk, but iirc the problem was local to my machine.

@artlogic
Copy link
Collaborator

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants