Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #182: Updates Minimal Mistakes theme in _config.yaml #184

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

SKBruck
Copy link
Collaborator

@SKBruck SKBruck commented Dec 19, 2023

No description provided.

@vielmetti
Copy link
Collaborator

I checked this version out, installed Ruby 3.2.2 using Homebrew on my MacBook, ran "bundle exec jekyll serve" as directed; it errored out and asked me to do "bundle install" first. Did that, then started up Jekyll, navigated to the localhost:4000 site, and all looks well.

Which is a long way of saying "looks good to me", no obvious problems here.

Copy link
Collaborator

@vielmetti vielmetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a test deployment on my local system didn't have any obvious issues.

@artlogic artlogic merged commit 34352b9 into master Dec 24, 2023
1 check passed
@artlogic artlogic deleted the update/minimal-mistakes-update/182 branch December 24, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants