Export types engine default features #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
|
I think we can do 'default = ["alloy-rpc-types-engine/default"]'? |
grandizzy
force-pushed
the
engine-default-features
branch
from
a6918b2
to
c9219de
Compare
DaniPopes
approved these changes
Aug 13, 2024
mattsse
reviewed
Aug 13, 2024
crates/rpc-types/Cargo.toml
Outdated
| @@ -34,7 +34,7 @@ serde = { workspace = true, features = ["derive", "std"]} | |||
| serde_json.workspace = true | |||
|
|
|||
| [features] | |||
| default = ["eth"] | |||
| default = ["eth", "alloy-rpc-types-engine/default"] | |||
There was a problem hiding this comment.
does this pull in the engine types now by default?
should this use the alloy-rpc-types-engine?/default notation?
grandizzy
force-pushed
the
engine-default-features
branch
from
c9219de
to
fa1a8cf
Compare
mattsse
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Include default features of engine types in rpc-types meta crate.
Solution
PR Checklist