Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow arbitrary strings in subscription ids #1163

Merged
merged 3 commits into from
Aug 21, 2024
Merged

fix: allow arbitrary strings in subscription ids #1163

merged 3 commits into from
Aug 21, 2024
+39 −26

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Aug 20, 2024 •
edited
Loading

Motivation

Closes #1158

This adds SubId enum similar to json_rpc::Id but without None variant and with U256 in place of Number variant.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@klkvr klkvr changed the title fix: use json_rpc::Id for subscription id fix: allow arbitrary strings in subscription ids Aug 20, 2024
mattsse
mattsse approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

@mattsse mattsse merged commit cab3e08 into main Aug 21, 2024
26 checks passed
@mattsse mattsse deleted the klkvr/sub-ids branch August 21, 2024 05:31
@mattsse mattsse mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support arbitrary subscription ids
2 participants
@klkvr @mattsse