Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Introduce Block type in alloy-consensus #1290

Closed
mattsse opened this issue Sep 14, 2024 · 1 comment
Closed

[Feature] Introduce Block type in alloy-consensus #1290

mattsse opened this issue Sep 14, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented Sep 14, 2024

Component

consensus, eips, genesis

Describe the feature you would like

currently we don't have a block type in the consensus crate

ref

https://github.com/paradigmxyz/reth/blob/97cc9dd8ecaaf7ebfa0b401ed080da28dc791376/crates/primitives/src/block.rs#L28-L48

this type should be structured slightly differently, so that there's a body container struct that wraps transactions, requests, withdrawals

which is this type

https://github.com/paradigmxyz/reth/blob/97cc9dd8ecaaf7ebfa0b401ed080da28dc791376/crates/primitives/src/block.rs#L557-L566

Additional context

No response

@yash-atreya
Copy link
Member

Closed by #1319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants