fix: map deserde error to ErrorResp if it is an error payload #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
mattsse
force-pushed
the
matt/try-deserializing-error-payload
branch
from
ca4889f
to
00fa9e6
Compare
DaniPopes
approved these changes
Feb 28, 2024
|
check if this logic error is duplicated in the other transports? Maybe make a convenience function in the jsonrpc crate for doing this conversion? |
|
we could add it to |
DaniPopes
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently all deserde failures are returned as
deser_errorthis adds a check for error payload if deserialization failed