Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incosistent naming for HDPath #332

Closed
klkvr opened this issue Mar 18, 2024 · 1 comment
Closed

Incosistent naming for HDPath #332

klkvr opened this issue Mar 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@klkvr
Copy link
Member

klkvr commented Mar 18, 2024

Component

signers

Describe the feature you would like

For Ledger signer DerivationType is aliased as HDPath:

pub use types::{DerivationType as HDPath, LedgerError};

For Trezor signer, TrezorHDPath is used:

pub use types::{DerivationType as TrezorHDPath, TrezorError};

this probably came from ethers which has same naming, perhaps we can fix it now in Alloy?

Additional context

No response

@klkvr klkvr added the enhancement New feature or request label Mar 18, 2024
@klkvr
Copy link
Member Author

klkvr commented Mar 18, 2024

Closing in favor of #292

@klkvr klkvr closed this as completed Mar 18, 2024
@DaniPopes DaniPopes closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants