Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add block_time_f64 to Anvil #336

Merged
merged 2 commits into from
Mar 19, 2024
Merged

add block_time_f64 to Anvil #336

merged 2 commits into from
Mar 19, 2024

Conversation

lakshya-sky
Copy link
Contributor

Motivation

Fixes: #285

Solution

  • add block_time_f64 method for Anvil.
  • change block_time to be f64.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

DaniPopes
DaniPopes approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a minor nit.

crates/node-bindings/src/anvil.rs Show resolved Hide resolved
@lakshya-sky @DaniPopes
also check if it spawns correctly.
c780844 
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
@lakshya-sky lakshya-sky requested a review from DaniPopes March 18, 2024 19:05
@mattsse mattsse merged commit f2518c4 into alloy-rs:main Mar 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add block_time_f64 to Anvil
3 participants
@lakshya-sky @mattsse @DaniPopes