Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oversight from #349 Lazy<KzgSettings> was not moved from Reth to alloy-eips #384

Closed
developeruche opened this issue Mar 24, 2024 · 0 comments · Fixed by #385
Closed

Oversight from #349 Lazy<KzgSettings> was not moved from Reth to alloy-eips #384

developeruche opened this issue Mar 24, 2024 · 0 comments · Fixed by #385
Labels
enhancement New feature or request

Comments

@developeruche
Copy link
Contributor

Component

consensus, eips, genesis

Describe the feature you would like

From this issue, KZG related constants and util function from REVM and RETH moved to eips/4844.rs,

pub static MAINNET_KZG_TRUSTED_SETUP: Lazy<Arc<KzgSettings>> = Lazy::new(|| {
        Arc::new(
            c_kzg::KzgSettings::load_trusted_setup(
                &revm_primitives::kzg::G1_POINTS.0,
                &revm_primitives::kzg::G2_POINTS.0,
            )
            .expect("failed to load trusted setup"),
        )
    });

was omitted.

Additional context

https://github.com/paradigmxyz/reth/blob/c868c52063a7f507f2a455a752e159c9b5f08402/crates/primitives/src/constants/eip4844.rs#L18C5-L26C8

@developeruche developeruche added the enhancement New feature or request label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant