Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: small fixes for Transaction #388

Merged
merged 4 commits into from
Mar 25, 2024
Merged

fix: small fixes for Transaction #388

merged 4 commits into from
Mar 25, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Mar 24, 2024

Motivation

  1. Make Transaction::blob_versioned_hashes an Option so that we can determine if it was not present or just empty. This field has similar semantics to access_list
  2. EIP-1559 txs include deprecated gasPrice field:
    image
    We have to account for it when converting to TransactionRequest to not end up with invalid request having both gasPrice and maxFeePerGas.

@prestwich
Copy link
Member

please link source of screenshot

@klkvr
Copy link
Member Author

klkvr commented Mar 24, 2024

@prestwich https://ethereum.github.io/execution-apis/api-documentation/ eth_getTransactionByHash section
https://github.com/ethereum/execution-apis/blob/main/src/schemas/transaction.yaml#L124

mattsse
mattsse approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

this is better, this should indeed be skipped if None, and using an option makes it possible to distinguish between blob vs non-blob

onbjerg
onbjerg approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursed spec

@prestwich prestwich merged commit f7333c4 into alloy-rs:main Mar 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klkvr @prestwich @onbjerg @mattsse