Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider): geth txpool_* methods #546

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat(provider): geth txpool_* methods #546

merged 1 commit into from
Apr 15, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Ref #502. Unblocks anvil integration tests migration

Solution

Implement Provider extension trait TxPoolApi which contains the necessary methods.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya
Copy link
Member Author

Note: Also changes rpc_types::txpool::* to primitive types for gas and gas_price.

mattsse
mattsse approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

the type changes also lgtm

@mattsse mattsse merged commit 75d2f44 into alloy-rs:main Apr 15, 2024
18 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@yash-atreya
feat(provider): geth txpool_* methods (alloy-rs#546)
9c9b6a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-atreya @mattsse