[Blocked] Update TransactionRequest's to field to TxKind
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
Apr 17, 2024
prestwich
reviewed
Apr 17, 2024
prestwich
requested changes
Apr 17, 2024
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
Evalir
as code owners
prestwich
changed the title
to field to TxKindto field to TxKind
|
This is now blocked by sol! expansion changes that i can work on soon |
3 tasks
|
mututally dependent with alloy-rs/core#606 |
DaniPopes
reviewed
Apr 19, 2024
gakonst
reviewed
Apr 19, 2024
| @@ -266,7 +266,7 @@ mod tests { | |||
| let tx = TransactionRequest { | |||
| from: Some(anvil.addresses()[0]), | |||
| value: Some(U256::from(100)), | |||
| to: address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into(), | |||
| to: Some(address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into()), | |||
There was a problem hiding this comment.
should these be using TransactionBuilder instead of defining the transaction fully?
There was a problem hiding this comment.
yeah but its just tests so i didn't want to clutter the diff
|
currently blocked by updating to a version of alloy-core with the new sol! expansion |
|
Unblocked now alloy-rs/core@9ff1e5a -- @DaniPopes should we cut core release? |
DaniPopes
approved these changes
Apr 23, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
) * feat: change the `to` field type to TxKind, update From<TxEip4844> accordingly * refactor: update builder functions to include `to` checks. * feat: add as_create(), with_call(), and deploy_code() * refactor: remove error lines * feat: with_call impl. * feat: add the methods to the builder trait, update code that was broken. * test: update tests. * nits: reordering and default impls * fix: some test compilation * nit: fmt * lint: clippy * test: fix tests * refactor: kind vs to * feat: new_raw_deploy and generic input * doc: add note re sol usage * fix: type inference in test * chore: update core * docs --------- Co-authored-by: James <james@prestwi.ch> Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue #549
Solution
Note: This is not the full refactor, I'll mark it ready for review once it's done :)
From the issue:
[X] Modify to field to make creates explicit
[X] Error on non-4844 build if to is unset
[X] Error on 4844 build if to is unset or create
[X] Add following to the builder trait
PR Checklist