chore: remove rlp encoding for Request
#751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the EIP was a bit ambigious here, apparently we are not supposed to also RLP encode the result of the EIP-7685 encoding. instead, to compute the request root, we should just stuff the EIP-7685 encoded request into a list and RLP encode that list this simply removes the unneeded RLP encoding
onbjerg
requested review from
DaniPopes,
gakonst,
mattsse,
prestwich and
Evalir
as code owners
mattsse
approved these changes
May 15, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
the EIP was a bit ambigious here, apparently we are not supposed to also RLP encode the result of the EIP-7685 encoding. instead, to compute the request root, we should just stuff the EIP-7685 encoded request into a list and RLP encode that list this simply removes the unneeded RLP encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the EIP was a bit ambigious here, apparently we are not supposed to also RLP encode the result of the
EIP-7685 encoding. instead, to compute the request root, we should just stuff the EIP-7685 encoded request
into a list and RLP encode that list
this simply removes the unneeded RLP encoding. we could also have kept it around and simply do a
self.encode_7685(buf), but I think that would break expectations around how RLP works (geth does this)PR Checklist