fix: correctly serialize eth_call params #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
approved these changes
May 24, 2024
DaniPopes
force-pushed
the
dani/ethcall-overrides2
branch
from
ddedd19
to
8573efe
Compare
DaniPopes
force-pushed
the
dani/ethcall-overrides2
branch
from
8573efe
to
5610541
Compare
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullis invalid for state overrides, and also it's off spec so don't serialize it ifNone.This requires a manual
serde::Serializeimplementation since#[serde(skip_serializing_if)]does not work on tuple structs.Noticed in foundry-rs/foundry#7990
Regressed in #763