Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: HttpConnect #786

Merged
merged 2 commits into from
May 28, 2024
Merged

Feat: HttpConnect #786

merged 2 commits into from
May 28, 2024

Conversation

prestwich
Copy link
Member

Motivation

Close #397

Solution

  • Add HttpConnect to alloy_transport_http
  • Add TransportConnect impls
  • Add type aliases

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the debt Tech debt which needs to be addressed label May 27, 2024
@prestwich prestwich self-assigned this May 27, 2024
@prestwich prestwich changed the title Prestwich/http connect Feat: HttpConnect May 27, 2024
@prestwich prestwich merged commit ee7550c into main May 28, 2024
24 checks passed
@prestwich prestwich deleted the prestwich/http-connect branch May 28, 2024 09:21
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@prestwich
Feat: HttpConnect (alloy-rs#786)
d762edc 
* feature: HttpConnect

* fix: imports and FromStr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees

@prestwich prestwich

Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Missing HttpConnect in alloy-transport-http
2 participants
@prestwich @DaniPopes