Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: put wasm-bindgen-futures dep behind the wasm-bindgen feature flag #795

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented May 28, 2024

Closes #792

@leruaa
Copy link
Contributor Author

leruaa commented May 28, 2024

fyi, wasm-bindgen is brought by a few other paths:

cargo tree --target wasm32-unknown-unknown

alloy v0.1.0 (/workspaces/crypto/alloy/crates/alloy)
├── alloy-core v0.7.2
│   └── alloy-primitives v0.7.2
│       ├── getrandom v0.2.12
│       │   ├── cfg-if v1.0.0
│       │   ├── js-sys v0.3.69
│       │   │   └── wasm-bindgen v0.2.92
│       │   └── wasm-bindgen v0.2.92 (*)
└── reqwest v0.12.1
    ├── wasm-bindgen v0.2.92 (*)
    ├── wasm-bindgen-futures v0.4.42
    │   └── wasm-bindgen v0.2.92 (*)
    └── web-sys v0.3.69
        └── wasm-bindgen v0.2.92 (*)
alloy-contract v0.1.0 (/workspaces/crypto/alloy/crates/contract)
├── alloy-provider v0.1.0 (/workspaces/crypto/alloy/crates/provider)
│   ├── alloy-rpc-client v0.1.0 (/workspaces/crypto/alloy/crates/rpc-client)
│   │   ├── alloy-transport-ws v0.1.0 (/workspaces/crypto/alloy/crates/transport-ws)
│   │   │   └── ws_stream_wasm v0.7.4
│   │   │       ├── wasm-bindgen v0.2.92 (*)
│   │   │       ├── wasm-bindgen-futures v0.4.42 (*)
alloy-signer-ledger v0.1.0 (/workspaces/crypto/alloy/crates/signer-ledger)
├── coins-ledger v0.10.1
│   ├── wasm-bindgen v0.2.92 (*)
│   └── wasm-bindgen-futures v0.4.42 (*)

And also alloy-signer-gcp via gcloud-sdk -> reqwest

@DaniPopes DaniPopes merged commit fed49bb into alloy-rs:main Jun 11, 2024
22 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
…flag (alloy-rs#795)

* feat: put wasm-bindgen-futures dep behind the `wasm-bindgen` feature flag

* chore: move to [features], update CI

---------

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
@leruaa leruaa deleted the wasm_bindgen_feature branch October 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] make rpc-client and below wasm-friendlier
3 participants