rpc-types-eth: Add receipt deserialize tests for AnyTransactionReceipt
#868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prestwich I am currently working on tests to deserialize Optimism and Arbitrum transaction receipts. What should I set as the RPC URL for these networks? I noticed that Ethereum utilizes Alchemy's API endpoint ( |
moricho
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
moricho
changed the title
AnyNetwork
mattsse
requested changes
Jun 11, 2024
| #[ignore] | ||
| async fn gets_tx_receipt_opt() { | ||
| init_tracing(); | ||
| let url = "https://opt-mainnet.g.alchemy.com/v2/demo"; |
There was a problem hiding this comment.
we want avoid using live rpc providers because this can degrade CI drastically.
for these tests we should use the raw json objects and test deserialization like this.
moricho
force-pushed
the
any-network-test
branch
from
72c728e
to
2ab5dd7
Compare
mattsse
approved these changes
Jun 12, 2024
moricho
changed the title
AnyNetworkAnyTransactionReceipt
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…pt` (alloy-rs#868) * provider: Add receipt deserialize tests for AnyNetwork * rpc-type-eth: Add tests to deserialize `AnyTransactionReceipt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To ensure that the fields present in the tx receipt for Arbitrum and Optimism are captured correctly
from: #424
Solution
PR Checklist